Today Chrisopher checked my pull request as regards the color space conversion module.
The PR can be found here:
The main issues that must be fixed are:
- PEP8 code refactoring
- Interfaces change (add enable_in as data_valid in interfaces)
- Add docstring comments in interfaces and in blocks
- Add a comment pointing to the wikipedia page or the JFIF standard for the coefficients
Also with some discussion with Nikolaos we agreed that the the converted code of the module and the testbenches must be verified for MyHDL, Verilog and VHDL.
In the following commits the above issues will be fixed.
No comments:
Post a Comment